Add more details on the proposal.#6
Open
brendandahl wants to merge 2 commits into
Open
Conversation
brendandahl
force-pushed
the
phase2-details
branch
from
660c2d6 to
f25d544
Compare
rossberg
reviewed
Jun 17, 2026
rossberg
left a comment
rossberg
left a comment
Member
There was a problem hiding this comment.
In addition to the editorial tweaks/corrections below, I would suggest two changes to the binary format:
- Bit 6 and 4 are closely related, in that they control the target for the operation. Can we move them together, i.e., use bit 5 instead of 4? Then we can more easily read them as a single two-bit value and extend its interpretation in the future (e.g., by using the combination 11 for another form of target, such as first-class memories).
- Memory index and type index are mutually exclusive, have the same format, and take similar roles. It would make sense to put them in the same position in the binary format. That would also simplify decoding (you parse an index unless both bits 4 and 6 are zero).
Collaborator
Author
|
Thanks for the review!
Bit 5 is currently used in the relaxed atomics proposal. We could potentially swap with them if you feel strongly about this. |
Member
|
Yeah, given that both proposals are in early stages, I assume it's not a big deal to switch the bits. I think it would be worthwhile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.